New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zcash: 1.0.13 -> 2.1.0-1 #73353
zcash: 1.0.13 -> 2.1.0-1 #73353
Conversation
e62bd83
to
e8a5012
Compare
|
||
installPhase = '' | ||
mkdir -p $out/lib | ||
cp target/release/librustzcash.a $out/lib/ | ||
mkdir -p $out/include | ||
cp include/librustzcash.h $out/include/ | ||
cp librustzcash/include/librustzcash.h $out/include/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there an update in how librustzcash
was fetched from github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it now has multiple sub-projects, the main one of which is in the directory librustzcash
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I see.
''; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not. I should have added a comment in hindsight. Without this line, it runs cargo test
in their rust workspace. These appear quite substantial (and single threaded) - I left them running for the best part of yesterday on my pc before giving up and going to bed, hence why I felt it best to disable them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense.
This patch LGTM. |
e8a5012
to
cc1568d
Compare
Minor delta: I removed the dependency on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with nix-review
Motivation for this change
Zcash is severely outdated, and is incompatible with the live network.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @rht